Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

184 - Ignore rule comments #200

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

github-actions[bot]
Copy link

Solves #184

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/184-ignore-rule-comments-staging branch 2 times, most recently from d0c4c68 to 97c65aa Compare November 6, 2023 18:37
@EnergyCube EnergyCube force-pushed the feature/184-ignore-rule-comments-staging branch 2 times, most recently from 3c0cdf1 to a6f428e Compare November 8, 2023 13:36
@EnergyCube EnergyCube force-pushed the feature/184-ignore-rule-comments-staging branch from a46993f to 74eba24 Compare November 16, 2023 11:47
@0xmemorygrinder 0xmemorygrinder force-pushed the dev branch 5 times, most recently from f87bf0b to 7369634 Compare November 22, 2023 23:19
@EnergyCube EnergyCube force-pushed the feature/184-ignore-rule-comments-staging branch from 74eba24 to 021b1e1 Compare November 26, 2023 19:07
@EnergyCube EnergyCube marked this pull request as ready for review November 26, 2023 20:59
@0xtekgrinder 0xtekgrinder self-assigned this Nov 28, 2023
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the ability to disable multiple rules within the same comment such as // solidhunter-disable-line exist-with-error avoid-tx-origin ?

remove-me-536c835ec85f45efaf8e.txt Outdated Show resolved Hide resolved
@EnergyCube EnergyCube force-pushed the feature/184-ignore-rule-comments-staging branch from c2856b4 to 7547a8e Compare November 30, 2023 18:11
Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xmemorygrinder 0xmemorygrinder force-pushed the feature/184-ignore-rule-comments-staging branch from 7547a8e to b489dae Compare December 1, 2023 17:01
@0xmemorygrinder 0xmemorygrinder force-pushed the feature/184-ignore-rule-comments-staging branch from b489dae to a4c0305 Compare December 1, 2023 17:02
@0xmemorygrinder 0xmemorygrinder merged commit 296afcc into dev Dec 1, 2023
24 checks passed
@0xmemorygrinder 0xmemorygrinder deleted the feature/184-ignore-rule-comments-staging branch December 1, 2023 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants