This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmemorygrinder
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
2 times, most recently
from
November 6, 2023 18:37
d0c4c68
to
97c65aa
Compare
EnergyCube
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
2 times, most recently
from
November 8, 2023 13:36
3c0cdf1
to
a6f428e
Compare
EnergyCube
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
from
November 16, 2023 11:47
a46993f
to
74eba24
Compare
0xmemorygrinder
force-pushed
the
dev
branch
5 times, most recently
from
November 22, 2023 23:19
f87bf0b
to
7369634
Compare
EnergyCube
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
from
November 26, 2023 19:07
74eba24
to
021b1e1
Compare
0xtekgrinder
suggested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the ability to disable multiple rules within the same comment such as // solidhunter-disable-line exist-with-error avoid-tx-origin ?
EnergyCube
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
from
November 30, 2023 18:11
c2856b4
to
7547a8e
Compare
0xtekgrinder
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xmemorygrinder
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
from
December 1, 2023 17:01
7547a8e
to
b489dae
Compare
0xmemorygrinder
force-pushed
the
feature/184-ignore-rule-comments-staging
branch
from
December 1, 2023 17:02
b489dae
to
a4c0305
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #184