This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
207 - Integrate foundry tests #214
Merged
0xmemorygrinder
merged 17 commits into
dev
from
feature/207-integrate-foundry-tests-staging
Jan 10, 2024
Merged
207 - Integrate foundry tests #214
0xmemorygrinder
merged 17 commits into
dev
from
feature/207-integrate-foundry-tests-staging
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmemorygrinder
force-pushed
the
feature/207-integrate-foundry-tests-staging
branch
2 times, most recently
from
December 6, 2023 05:38
20aa5a2
to
50f7a1f
Compare
0xmemorygrinder
force-pushed
the
feature/207-integrate-foundry-tests-staging
branch
2 times, most recently
from
December 15, 2023 18:26
7d3318f
to
51bee47
Compare
0xSwapFeeder
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few cleaning left to do but lgtm 👍
0xtekgrinder
suggested changes
Jan 9, 2024
toolchains/solidity/core/crates/tests-positions-server/src/main.rs
Outdated
Show resolved
Hide resolved
…retrieve contracts and tests positions
…structure to add contract and tests names
…tract tests were relaunching all children tests
… based on foundry naming convention
0xmemorygrinder
force-pushed
the
feature/207-integrate-foundry-tests-staging
branch
from
January 10, 2024 00:39
8de3b03
to
ff9213d
Compare
0xtekgrinder
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0xmemorygrinder
deleted the
feature/207-integrate-foundry-tests-staging
branch
January 10, 2024 16:02
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #207