Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
pyproject.toml
configuration by lowering the minimum required version ofscipy
from1.13
to1.10
. This change addresses anImportError
encountered by users attempting to importMovingBlockBootstrap
from thetsbootstrap
library when usingscipy
versions1.13
and above. Specifically, the error:ImportError: cannot import name 'gaussian' from 'scipy.signal'
occurs because the
gaussian
function was removed or relocated in newer versions ofscipy
. By allowingscipy>=1.10
, this PR ensures compatibility with versions that still include the necessarygaussian
function, thereby resolving the import issue without sacrificing existing functionality.Issue Addressed:
A user reported that importing
MovingBlockBootstrap
results in anImportError
due to incompatibility withscipy
versions>=1.13
. Downgrading toscipy
1.10
resolves the error, but the package's currentpyproject.toml
restrictsscipy
to>=1.13
, preventing this workaround.Type of change
How Has This Been Tested?
The changes were tested through the following steps:
Environment Setup:
scipy
version1.10.0
.tsbootstrap
from the current branch.Import Verification:
MovingBlockBootstrap
without encountering theImportError
.Functionality Testing:
tsbootstrap
operate as expected withscipy
1.10.0
.Compatibility Check:
scipy
versions>=1.10
and<1.14.0
as specified.Checklist:
Additional Information (if applicable)
Reason for Version Downgrade:
The
gaussian
function required bytsbootstrap
was removed or altered inscipy
versions>=1.13
, causing the import error. Downgrading toscipy
1.10
reinstates the necessary functionality.Potential Impact:
Users relying on
scipy
versions>=1.13
will need to usescipy
<1.14.0
to maintain compatibility withtsbootstrap
. This adjustment broadens the range of compatiblescipy
versions, allowing more flexibility for users who may need to use older versions.