Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TAP job deletion optional defaulting to True #640

Merged
merged 4 commits into from
Jan 16, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
DOC: Add PR number to changelog
bsipocz authored Jan 16, 2025
commit f765128c60f10c11907db6b81b1fe1544ee4d917
2 changes: 1 addition & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
Enhancements and Fixes
----------------------

- Make deletion of TAP jobs optional via a delete flag. Default: True
- Make deletion of TAP jobs optional via a new ``delete`` kwarg. [#640]

Deprecations and Removals
-------------------------

Unchanged files with check annotations Beta

the job is deleted. Any deletion errors are silently ignored
to ensure proper context exit.
"""
if self._delete_on_exit:
try:
self.delete()
except DALServiceError:
pass

Check warning on line 684 in pyvo/dal/tap.py

Codecov / codecov/patch

pyvo/dal/tap.py#L680-L684

Added lines #L680 - L684 were not covered by tests
def _update(self, wait_for_statechange=False, timeout=10.):
"""