Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · 9960016 · 9960016
1 parent 9b09be5
commit 9960016
Show file tree

Hide file tree

Showing 9 changed files with 28 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 1.0.2
 
 ### Changed

diff --git a/src/Input/CalculateRouteMatrixRequest.php b/src/Input/CalculateRouteMatrixRequest.php
@@ -275,7 +275,10 @@ public function getTruckModeOptions(): ?CalculateRouteTruckModeOptions
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/CalculateRouteRequest.php b/src/Input/CalculateRouteRequest.php
@@ -354,7 +354,10 @@ public function getWaypointPositions(): array
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/SearchPlaceIndexForPositionRequest.php b/src/Input/SearchPlaceIndexForPositionRequest.php
@@ -141,7 +141,10 @@ public function getPosition(): array
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/SearchPlaceIndexForTextRequest.php b/src/Input/SearchPlaceIndexForTextRequest.php
@@ -236,7 +236,10 @@ public function getText(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/tests/Unit/Input/CalculateRouteMatrixRequestTest.php b/tests/Unit/Input/CalculateRouteMatrixRequestTest.php
@@ -43,7 +43,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/location/latest/APIReference/API_CalculateRouteMatrix.html
         $expected = '
             POST /routes/v0/calculators/CalculatorName/calculate/route-matrix HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
               "DepartNow": false,

diff --git a/tests/Unit/Input/CalculateRouteRequestTest.php b/tests/Unit/Input/CalculateRouteRequestTest.php
@@ -45,7 +45,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/location/latest/APIReference/API_CalculateRoute.html
         $expected = '
             POST /routes/v0/calculators/CalculatorName/calculate/route HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                 "DepartNow": false,

diff --git a/tests/Unit/Input/SearchPlaceIndexForPositionRequestTest.php b/tests/Unit/Input/SearchPlaceIndexForPositionRequestTest.php
@@ -19,7 +19,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/location/latest/APIReference/API_SearchPlaceIndexForPosition.html
         $expected = '
             POST /places/v0/indexes/IndexName/search/position HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                 "Language": "en",

diff --git a/tests/Unit/Input/SearchPlaceIndexForTextRequestTest.php b/tests/Unit/Input/SearchPlaceIndexForTextRequestTest.php
@@ -22,7 +22,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/location/latest/APIReference/API_SearchPlaceIndexForText.html
         $expected = '
             POST /places/v0/indexes/IndexName/search/text HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
               "BiasPosition": [