Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · 842e3b1 · 842e3b1
1 parent ac7bb96
commit 842e3b1
Show file tree

Hide file tree

Showing 11 changed files with 34 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 1.2.0
 
 ### Added

diff --git a/src/Input/CancelJobRequest.php b/src/Input/CancelJobRequest.php
@@ -55,7 +55,10 @@ public function getId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/CreateJobRequest.php b/src/Input/CreateJobRequest.php
@@ -286,7 +286,10 @@ public function getUserMetadata(): array
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/DescribeEndpointsRequest.php b/src/Input/DescribeEndpointsRequest.php
@@ -89,7 +89,10 @@ public function getNextToken(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/GetJobRequest.php b/src/Input/GetJobRequest.php
@@ -55,7 +55,10 @@ public function getId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/ListJobsRequest.php b/src/Input/ListJobsRequest.php
@@ -124,7 +124,10 @@ public function getStatus(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/tests/Unit/Input/CancelJobRequestTest.php b/tests/Unit/Input/CancelJobRequestTest.php
@@ -16,7 +16,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/mediaconvert/latest/apireference/API_CancelJob.html
         $expected = '
             DELETE /2017-08-29/jobs/ZJ1648461 HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
                 ';
 

diff --git a/tests/Unit/Input/CreateJobRequestTest.php b/tests/Unit/Input/CreateJobRequestTest.php
@@ -1853,7 +1853,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/mediaconvert/latest/apireference/API_CreateJob.html
         $expected = '
             POST /2017-08-29/jobs HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                 "accelerationSettings": {

diff --git a/tests/Unit/Input/DescribeEndpointsRequestTest.php b/tests/Unit/Input/DescribeEndpointsRequestTest.php
@@ -19,7 +19,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/mediaconvert/latest/apireference/API_DescribeEndpoints.html
         $expected = '
             POST /2017-08-29/endpoints HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                 "maxResults": 1337,

diff --git a/tests/Unit/Input/GetJobRequestTest.php b/tests/Unit/Input/GetJobRequestTest.php
@@ -16,7 +16,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/mediaconvert/latest/apireference/API_GetJob.html
         $expected = '
             GET /2017-08-29/jobs/ZJ1648461 HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
                 ';
 

diff --git a/tests/Unit/Input/ListJobsRequestTest.php b/tests/Unit/Input/ListJobsRequestTest.php
@@ -22,7 +22,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/mediaconvert/latest/apireference/API_ListJobs.html
         $expected = '
             GET /2017-08-29/jobs?maxResults=1337&nextToken=fakeToken&order=ASCENDING&queue=fakeQueue&status=COMPLETE HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
                 ';