-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply automated cargo clippy --fix #69
Conversation
oh right, we're testing 1.39 in CI. Though we don't advertise an MSRV, I don't want to think about loosening that right now. Closing this now. |
otherwise CI doesn't build
Retrying this; apparently our deps depend on Rust 1.56 or higher - so we need to bump the CI version anyway. That's fine; updating. |
The reason for this patch is that #66 was just merged; and I want to make sure that the main branch has a passing CI before doing a release. That requires among other things disabling the "warnings === errors" check, and for good measure we've also applied a |
Seems like it needs 1.60 as a minimum. Bumped! |
We went from Rust 1.39 to 1.63 as a minimum. At this point we might as well drop trying to test for older Rust versions given we don't guarantee an MSRV anyway. This shouldn't break any code right now, but should at least ensure that our CI stops breaking (because our dependencies don't guarantee an MSRV either). |
No description provided.