-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Feature ] Add proxy support for the generate from template command #1621
[ Feature ] Add proxy support for the generate from template command #1621
Comments
@AayushSaini101 I want to work on it... Please assign me. |
@IITI-tushar sure |
Thanks, I will open a PR soon. |
can I too work on this? @AayushSaini101 |
@AayushSaini101 in commands/generate folder should i have to add proxy support to all three fromTemplate.ts , index.ts and models.ts files ??? |
|
@IITI-tushar already working on this issue : ) |
@AayushSaini101 looks like the pr has been inactive for quite some time. Can i continue with this issue. Thanks. |
sure please thanks @neoandmatrix |
Thanks on it now. |
@AayushSaini101 while implementing this feature for the generate command i was going through the already implemented proxy support for
This can be also confirmed from running the command. both command should output similar error but using flag gives correct error I guess the implementation should only be for flags as it makes more sense because passing with flags is a more cleaner implementation in my opinion. I also might be mis understanding the implementation of this feature if that is the case please correct, will be very helpful. So i wanted to ask that for this command should i go with arguments or flags method. Please clarify so that i can proceed with implementation of this feature. Thanks. |
@neoandmatrix yes we are using flags in the existing commands |
@AayushSaini101 should i also make the changes for existing commands and remove the proxyHost and proxyPort form arguments as it can be misleading to users by opening a new issue for this and making a PR there? Thanks. |
Why do we need this improvement?
We have already introduced proxy support in multiple commands of cli, reference: #1608 Need to add support in generate command as well.
How will this change help?
we can use the generate command behind the proxy as well.
Screenshots
No response
How could it be implemented/designed?
Reference:https://www.zenrows.com/blog/node-fetch-proxy#how-to-use-proxy-with-node-fetch of the implementation flow of the proxy
🚧 Breaking changes
No
👀 Have you checked for similar open issues?
🏢 Have you read the Contributing Guidelines?
Are you willing to work on this issue?
No, someone else can work on it.
The text was updated successfully, but these errors were encountered: