Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: config command UI/UX improvement. #1643

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

neoandmatrix
Copy link
Contributor

Description

This PR implements the UI/UX improvements to the config command.
The changes are based on the previous PR
Tests are also updated for the same.

Related issue(s)
Resolves #1380

Below are attached changes result to the command :-

config versions

23_01_2025_WindowsTerminal_36_38

config analytics

23_01_2025_WindowsTerminal_14_43

config analytics -s

23_01_2025_WindowsTerminal_14_57

config context init .

23_01_2025_WindowsTerminal_15_31

config context current

23_01_2025_WindowsTerminal_16_09

config context add test-context .

23_01_2025_WindowsTerminal_18_11

config context use test-context

23_01_2025_WindowsTerminal_18_44

config context current

23_01_2025_WindowsTerminal_19_06

config context edit test-context ./

23_01_2025_WindowsTerminal_20_43

config context list

23_01_2025_WindowsTerminal_22_13

config context remove test-context

23_01_2025_WindowsTerminal_22_47

@AayushSaini101 please review.
Thanks.

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 4ff7c68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@asyncapi/cli Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@AayushSaini101 AayushSaini101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AayushSaini101
Copy link
Collaborator

@Souvikns @Shurtu-gal Need your review as well

@Shurtu-gal
Copy link
Collaborator

It would be great if images of output and design in figma are attached as well.

@neoandmatrix
Copy link
Contributor Author

It would be great if images of output and design in figma are attached as well.

Sorry but I don't have the figma file. I had made these design changes based on this PR design changes.

@Shurtu-gal
Copy link
Collaborator

@neoandmatrix
Copy link
Contributor Author

neoandmatrix commented Jan 24, 2025

https://www.figma.com/file/9yt0aJh7cVoJHxXzDDb2lt/CLI-UI%2FUX-Project?type=design&node-id=195%3A762&mode=design&t=XeFNVy8nWiOjPVeC-1

Looking through these designs i couldn't find anything specific for config commands.
Should i attach any other similar command one?
And of the outputs i have already attached after changes.

@AayushSaini101
Copy link
Collaborator

/rtm

@asyncapi-bot asyncapi-bot merged commit 9817950 into asyncapi:master Jan 24, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement new UI/UX improvements in config command
4 participants