Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link date button to Google Calendar #148

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

manulpatel
Copy link
Contributor

Description
Fixes the link to Date button on 2023 Conference Website to Google Calendar Event.

Related issue(s)
Fixes #146

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 2b71f35
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6491d2d3d42d15000812bb15
😎 Deploy Preview https://deploy-preview-148--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@AceTheCreator
Copy link
Member

@manulpatel, your preview build failed due to you using target="_blank" without rel="noreferrer" (which implies rel="noopener") is a security risk in older browsers: see

@manulpatel
Copy link
Contributor Author

Oh! Sorry for the vulnerability risk. I have updated the PR.

@AceTheCreator AceTheCreator merged commit dc86a27 into asyncapi:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date button is not clickable
2 participants