Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing speed by skipping it for certain PRs #1335

Open
derberg opened this issue Jan 23, 2025 · 2 comments · Fixed by AdityaP700/generator#1 · May be fixed by #1339
Open

Improve testing speed by skipping it for certain PRs #1335

derberg opened this issue Jan 23, 2025 · 2 comments · Fixed by AdityaP700/generator#1 · May be fixed by #1339
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@derberg
Copy link
Member

derberg commented Jan 23, 2025

We have https://github.com/asyncapi/generator/blob/master/.github/workflows/pr-testing-with-test-project.yml that is really long running.

And it runs sometimes when it is not needed, when there are PRs from bots doing some simple changes, sometimes readme only.

Add to the workflow if statement that we already have in https://github.com/asyncapi/generator/blob/master/.github/workflows/if-nodejs-pr-testing.yml#L21

@derberg derberg added area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers labels Jan 23, 2025
@AdityaP700
Copy link

Hey @derberg ,Well i would like to work on it ,can you assign me this task to go ahead.

@Gmin2
Copy link
Collaborator

Gmin2 commented Jan 23, 2025

Hey @derberg ,Well i would like to work on it ,can you assign me this task to go ahead.

just submit a pr with working solution, we dont generally assign issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants