fix: skip unnecessary test runs for bot-generated and non-critical PRs #1339
Conversation
Fix/skip unnecessary tests
docs: update README.md for testing
Update pr-testing-with-test-project.yml
Update pr-testing-with-test-project.yml
AdityaP700
requested review from
derberg,
magicmatatjahu,
jonaslagoni and
asyncapi-bot-eve
as code owners
|
|
Hey @derberg ,done with the changes in the required file , do let me know of any further changes . Thanks |
AdityaP700
changed the title
AdityaP700
changed the title
AdityaP700
changed the title
|
LGTM :) |
|
Hey @derberg can you run the workflow. |
There was a problem hiding this comment.
Amazing PR @AdityaP700 just few suggestions to improve it more.
| should-test: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| run_tests: ${{ steps.check.outputs.run_tests }} | ||
| steps: | ||
| - name: Check if tests should run | ||
| id: check | ||
| run: | | ||
| # Skip for bot PRs with specific titles | ||
| if [[ "${{ github.actor }}" == "asyncapi-bot" && "${{ github.event.pull_request.title }}" =~ ^(ci:\ update|chore\(release\):) ]] || \ | ||
| [[ "${{ github.actor }}" == "allcontributors[bot]" && "${{ github.event.pull_request.title }}" =~ ^docs: ]]; then | ||
| echo "run_tests=false" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "run_tests=true" >> $GITHUB_OUTPUT | ||
| fi | ||
There was a problem hiding this comment.
Adding a new job on which the actual job to be done is dependent won't increase job setup time?
Instead, how's about adding an if clause just like it is done here
There was a problem hiding this comment.
I did tried adding but thought of optimising it a bit thus made it likewise ,anyway will look into it .
| test: | ||
| if: github.event.pull_request.draft == false | ||
| needs: should-test | ||
| if: needs.should-test.outputs.run_tests == 'true' && github.event.pull_request.draft == false |
There was a problem hiding this comment.
| if: needs.should-test.outputs.run_tests == 'true' && github.event.pull_request.draft == false | |
| if: needs.should-test.outputs.run_tests == true && github.event.pull_request.draft == false |
wrapping true in single quotes makes it string, although eventually, it results in a true statement (as strings are also considered to be true) so the workflow works as expected. But it's a good practice to use Booleans for truthy and falsy statements.
There was a problem hiding this comment.
Alright got it !! i took the assumptions so did such changes but anyway will resolve it .
|
Description
Related Issue(s)
Fixes Improve testing speed by skipping it for certain PRs #1335
Testing