Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout in RequestAsync if target pid not found #2096

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

AdamCLarsen
Copy link
Contributor

Description

This PR addresses a specific issue in the virtual actor handling mechanism. Previously, when sending a request to a virtual actor of a specific kind, and no cluster members were registered under that kind, the request would loop indefinitely, awaiting the joining of a member with the matching kind. If no cancelation token was passed in, it is possible to consume all resources in the sending process.

With the new changes introduced in this PR, such requests to virtual actors will now be governed by a timeout (ActorRequestTimeout). The request will now return TimeoutOrThrow();, if a cluster member corresponding to the requested kind is not found within this timeout period.

Important Consideration

It's important to note that some systems might have been built with the previous behavior in mind, i.e., waiting indefinitely for another member to join. This update could lead to timeouts in such systems, which were not previously encountered. Users should review their system's reliance on this behavior and make necessary adjustments.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

@rogeralsing rogeralsing merged commit 824c0cc into asynkron:dev Feb 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants