Added timeout in RequestAsync if target pid not found #2096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a specific issue in the virtual actor handling mechanism. Previously, when sending a request to a virtual actor of a specific kind, and no cluster members were registered under that kind, the request would loop indefinitely, awaiting the joining of a member with the matching kind. If no cancelation token was passed in, it is possible to consume all resources in the sending process.
With the new changes introduced in this PR, such requests to virtual actors will now be governed by a timeout (
ActorRequestTimeout
). The request will nowreturn TimeoutOrThrow();
, if a cluster member corresponding to the requested kind is not found within this timeout period.Important Consideration
It's important to note that some systems might have been built with the previous behavior in mind, i.e., waiting indefinitely for another member to join. This update could lead to timeouts in such systems, which were not previously encountered. Users should review their system's reliance on this behavior and make necessary adjustments.
Purpose
This pull request is a:
Checklist