Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for case where a TopicActor can continue sending messages to a member that no longer exists #2147

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

benbenwilde
Copy link
Contributor

Description

We had an issue where a client member would be shutdown, but a remaining member would keep trying to connect to it and failing forever. This was due to a subscription in the TopicActor to that removed member. Since it was a client member, it is not detected as a removal from the topology, which the TopicActor already watches to unsubscribe members that have shutdown but failed to unsubscribe.

This change adds a handler for DeadLetterResponses to the TopicActor in order to detect when it is no longer able to reach a node with subscriptions, which then removes the subscriptions for that node. A test that validates the new code is included.

A minor change has been added to the BatchingProducer as well so it can stop more quickly and cleanly when it's being disposed.

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit ace44fd into asynkron:dev Jan 28, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants