Code generation changes for verification #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-bucev
force-pushed
the
precise-bitindex
branch
from
e5ca9b4
to
cb639c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SEQUENCEOFloops are transformed into top-level recursive functionsImportant note
The
PUSCScalaTestfor Scala did notSystem.exitwith a non-zero code when a test failed, we therefore use to accept failing tests. This is now fixed. However, this unveils a bug in automatic test case generation: the compiler may generate invalid messages that are rejected while encoding, which cause test to fail even though the encoding/decoding functions are not (presumably) faulty. This bug affects all backends but it is only manifest for the Scala one because the other ones do not always check for message validity. As a temporary "fix", the tests that do not proceed to encode the messages are marked as passing.