Mark 3.1.5 #188
Merged
Mark 3.1.5 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczuj
reviewed
Jun 12, 2024
CHANGELOG.md
Outdated
| [Unreleased]: https://github.com/atlassian/aws-infrastructure/compare/release-3.1.5...master | ||
|
|
||
| ## 3.1.5 - 2024-06-12 | ||
| It was a botched 3.2.0 release. Switch to 3.2.0 instead. |
There was a problem hiding this comment.
Should there be a header for 3.2.0 release in this changelog?
There was a problem hiding this comment.
Not yet. The axion plugin can't release 3.2.0 from the commit tagged as 3.1.5. So I need any commit on top (this PR). I'll release 3.2.0 immediately after.
But I get your point. The changelog talks about something that doesn't exist yet, so it's prone to creating chaos when my promise gets interrupted/fails. 🤔
You're right, the text is de facto lying. I'll remove all mentions of the nonexistent 3.2.0
pczuj
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did tag release-3.2.0-alpha, but on the branch commit, not after the rebase/merge.
https://packages.atlassian.com/maven-central/com/atlassian/performance/tools/aws-infrastructure/3.1.5/