Bump Gradle and stuff #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczuj
reviewed
Jun 13, 2024
pczuj
previously approved these changes
Jun 13, 2024
dagguh
force-pushed
the
bump-gradle-and-stuff
branch
from
f78d7b7
to
5478967
Compare
|
Thanks mate! I appreciate the reviews and responsiveness. |
|
PS. pushed a YAML typo fix. |
pczuj
previously approved these changes
Jun 13, 2024
|
Bumped gradle-release detected illegal licenses and failed the build: Noice. Fixing... |
Merged
mgrzaslewicz
previously approved these changes
Jun 14, 2024
Bump via `./gradlew wrapper`, then bump the Gradle plugins, then rewrite the locks, then switch buildscans to develocity.
And rewrite locks.
Our `eachDependency.useVersion` is a hack.
And we accidentally overrode the Kotlin stdlib used by the compiler.
Maybe in the future we should consider an allowlist of configs to lock.
The compiler warning:
```
> Task :compileKotlin
Compilation with Kotlin compile daemon was not successful
java.lang.Exception: Parameter specified as non-null is null: method org.jetbrains.kotlin.incremental.CacheVersionsKt.customCacheVersionManager, parameter fileName
at org.jetbrains.kotlin.daemon.common.CompileService$CallResult$Error.get(CompileService.kt:60)
at org.jetbrains.kotlin.daemon.common.CompileService$CallResult$Error.get(CompileService.kt:59)
at org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork.compileWithDaemon(GradleKotlinCompilerWork.kt:192)
at org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork.compileWithDaemonOrFallbackImpl(GradleKotlinCompilerWork.kt:132)
at org.jetbrains.kotlin.compilerRunner.GradleKotlinCompilerWork.run(GradleKotlinCompilerWork.kt:100)
at org.jetbrains.kotlin.compilerRunner.GradleCompilerRunner.runCompilerAsync(GradleKotlinCompilerRunner.kt:152)
at org.jetbrains.kotlin.compilerRunner.GradleCompilerRunner.runCompilerAsync(GradleKotlinCompilerRunner.kt:147)
at org.jetbrains.kotlin.compilerRunner.GradleCompilerRunner.runJvmCompilerAsync(GradleKotlinCompilerRunner.kt:87)
at org.jetbrains.kotlin.gradle.tasks.KotlinCompile.callCompilerAsync$kotlin_gradle_plugin(Tasks.kt:409)
at org.jetbrains.kotlin.gradle.tasks.KotlinCompile.callCompilerAsync$kotlin_gradle_plugin(Tasks.kt:319)
at org.jetbrains.kotlin.gradle.tasks.AbstractKotlinCompile.execute(Tasks.kt:276)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125)
at org.gradle.api.internal.project.taskfactory.IncrementalTaskInputsTaskAction.doExecute(IncrementalTaskInputsTaskAction.java:47)
at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51)
...
Could not connect to kotlin daemon. Using fallback strategy.
```
Previous commit triggerred some compiler language level warnings. And some bad memories. Bumping Kotlin is never a pleasant journey. I'll harvest a bunch of fixes/workarounds worked out in aws-infrastructure and virtual-users. atlassian-labs/aws-resources@e89d41e
Since we have Build Scans, they already offer detaild test output. So we don't need to do anything special for CI. Locally, you have HTML reports linked in the terminal or live interactive logs in the IDE.
Most logic is expressed within the Gradle project.
Previously rewriting locks would include a FAIL for: `kotlinKlibCommonizerClasspath`.
Fix: ``` > Task :verifyLicensing FAILED Illegal license found 'BSD License' in 'com.atlassian.performance:selenium-js:1.0.1' Illegal license found 'BSD License' in 'com.atlassian.data:random-data:1.4.3' ```
Fix: ``` > Task :verifyLicensing FAILED Illegal license found 'No license found' in 'javax.activation:activation:1.1.1' ```
dagguh
force-pushed
the
bump-gradle-and-stuff
branch
from
dfcdc1b
to
999811a
Compare
Also, centralize the workaround.
|
Rebased after #193 |
mgrzaslewicz
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff might be big, but commits should make sense.