Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivrahim Khalil fixes #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivrahim-khalil
Copy link

Task completed

  1. Consistency on navigation bar.
  2. single-question.html is now linked on Question button.
  3. Join me is now linked with registration page.
  4. Ask is linked to ask-question.html
  5. Search result page has been created and linked to “Search” and tags on the “home page”
  6. Line 1115-1120 has been commented out on style.css to solve toggle hover issue.

Additional task:
As per conversation with Author and after the confirmation two additional work done:

  1. pulled below to the other CSS so that common classed does not conflict with other. This is to follow the CSS best practice.
  2. At the home page toggle hover issue has been solved

Task completed
1.	 Consistency on navigation bar. 
2.	single-question.html is now linked  on Question button.
3.	Join me is now linked with registration page.
4.	Ask is linked to ask-question.html
5.	Search result page has been created and linked to “Search” and tags on the “home page”
6.	Line 1115-1120 has been commented out on style.css to solve toggle hover issue. 



Additional task:
As per conversation with Author and after the confirmation two additional work done:
1.	<!-- CUSTOM STYLE CSS -->  pulled below to the other CSS so that common classed does not conflict with other. This is to follow the CSS best practice. 
2.	At the home page toggle hover issue has been solved
@ivrahim-khalil
Copy link
Author

Please have my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant