Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RetinaNet Plugin for object_detection package #37

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

NOEMOJI041
Copy link
Contributor

@NOEMOJI041 NOEMOJI041 commented Sep 17, 2023

  • Added RetinaNet Plugin
    image

The abundance of bounding boxes in RetinaNet screenshots results from the model's comprehensive exploration of potential object locations, ensuring precise object detection. To address concerns about visual clutter, we are currently developing a thresholding feature. This feature will allow users to set a confidence threshold, displaying only bounding boxes with scores above that threshold, providing a cleaner and more user-friendly experience.

Issue #8

@jasmeet0915 jasmeet0915 changed the title added RetinaNet Added RetinaNet Plugin for object_detection package Sep 18, 2023
@topguns837
Copy link
Contributor

topguns837 commented Sep 18, 2023

@NOEMOJI041 I have checked the P.R., everything works but please make these small changes :

  1. Remove these print statements
    image

  2. Remove the unecessary imports from https://github.com/atom-robotics-lab/ros-perception-pipeline/blob/c1aaa09de3b93f991217b45b4a4c77fa1c4afcc3/object_detection/object_detection/Detectors/RetinaNet.py#L6C2-L6C2
    image

@NOEMOJI041
Copy link
Contributor Author

@NOEMOJI041 I have checked the P.R., everything works but please make these small changes :

  1. Remove these print statements
    image
  2. Remove the unecessary imports from https://github.com/atom-robotics-lab/ros-perception-pipeline/blob/c1aaa09de3b93f991217b45b4a4c77fa1c4afcc3/object_detection/object_detection/Detectors/RetinaNet.py#L6C2-L6C2
    image
  1. Print statement is present in ObjectDetection.py file to remove, we need to make changes in the ObjectDetection.py file this PR is concentrated on changes related to RetinaNet we can create an issue for the same.
  2. Removed Unwanted Imports in commit 4f2a307

@topguns837
Copy link
Contributor

Good job @NOEMOJI041 . Merging the branches

@topguns837 topguns837 merged commit 71eb12b into develop Sep 18, 2023
@topguns837 topguns837 deleted the noemoji041/RetinaNet branch September 18, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants