Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

:fix: #245 #169 #170 #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

:fix: #245 #169 #170 #252

wants to merge 1 commit into from

Conversation

fnadeau
Copy link

@fnadeau fnadeau commented Nov 6, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Allow class declaration and inheritance to be on a separate line.
Also add support for virtual inheritance.

Alternate Designs

Parsing of "virtual" keyword could be done differently.

Benefits

Highlighting improvements.

Possible Drawbacks

In this scenario
class Mammal : virtual public virtual Animal {};
both virtual are highlighted.

Applicable Issues

#245 #169 #170

After Before
screenshot from 2017-11-06 16 54 28

Allow class declaration and inheritance to be on a separate line.
Also add support for virtual inheritance.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants