Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Wrong tokenization of extended scss class names #241

Open
aeschli opened this issue Nov 2, 2017 · 2 comments
Open

Wrong tokenization of extended scss class names #241

aeschli opened this issue Nov 2, 2017 · 2 comments

Comments

@aeschli
Copy link
Contributor

aeschli commented Nov 2, 2017

From @croccifixio on November 1, 2017 20:36

Steps to Reproduce:

  1. Create a class rule in an SCSS file.
  2. Extend the class using nesting and an &.
  3. Begin the name of the extension to the class with 2 or more hyphens.

screenshot from 2017-11-01 20-48-35

Based on the above screenshot, __element is tokenized as punctuation.definition.entity.css, which I suppose is alright.

However, --modifier is tokenized as variable.css which can lead to unsightly styling issues if the two tokens are styled differently in a particular theme (see the screenshot above).
Copied from original issue: microsoft/vscode#37444

@aeschli
Copy link
Contributor Author

aeschli commented Nov 2, 2017

@croccifixio Would be great if you make your pull request here (thanks @maxibanki)

@adamreisnz
Copy link

Not sure if this is the right issue to post this, but there seem to be quite a few issues with incorrect scopes in the last version of language-sass when nesting;

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants