Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tokenization of extended scss class names #37444

Closed
croccifixio opened this issue Nov 1, 2017 · 2 comments
Closed

Wrong tokenization of extended scss class names #37444

croccifixio opened this issue Nov 1, 2017 · 2 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling

Comments

@croccifixio
Copy link

  • VSCode Version: Code 1.17.2 (b813d12, 2017-10-16T13:57:00.652Z)
  • OS Version: Linux x64 4.13.0-16-generic

Steps to Reproduce:

  1. Create a class rule in an SCSS file.
  2. Extend the class using nesting and an &.
  3. Begin the name of the extension to the class with 2 or more hyphens.

screenshot from 2017-11-01 20-48-35

Based on the above screenshot, __element is tokenized as punctuation.definition.entity.css, which I suppose is alright.

However, --modifier is tokenized as variable.css which can lead to unsightly styling issues if the two tokens are styled differently in a particular theme (see the screenshot above).

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the css-less-scss Issues and items concerning CSS,Less,SCSS styling label Nov 1, 2017
@mxschmitt
Copy link
Member

mxschmitt commented Nov 1, 2017

We appreciate it, that you want to contribute, but please read the information in the file header:
https://github.com/Microsoft/vscode/blob/80efcf5fdee32f7249ad23011a2abc4254fc19de/extensions/scss/syntaxes/scss.json#L2-L6
So create a PR there. :)

@aeschli
Copy link
Contributor

aeschli commented Nov 2, 2017

This issue was moved to atom/language-sass#241

@aeschli aeschli closed this as completed Nov 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling
Projects
None yet
Development

No branches or pull requests

3 participants