-
Notifications
You must be signed in to change notification settings - Fork 193
Added support for armv7l arch (Raspberry Pi 32bit) #446
Conversation
@sergiou87 would you mind taking a look at this when you have a minute please? |
Yes, sorry! It's all looking good, let's see if CI gives us all 🟢 |
@nzapponi seems like it's not finding |
Whoops, sorry, my bad. Let me fix that |
This should do it @sergiou87 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for your contribution! ❤️
@sergiou87 do you have any plans to release a new version including this PR anytime soon? Thanks! |
No plans, but I will do one soon (hopefully this week). We're kind of busy with GitHub Desktop releases at the moment, sorry, but I will let you know 😄 |
@nzapponi 7.9.0 should be ready and include armv7l binaries 😄 Please let me know if that works |
That's awesome, thank you!! |
Requirements for Adding, Changing, or Removing a Feature
Issue or RFC Endorsed by Atom's Maintainers
#401
Description of the Change
Added support for prebuilt binaries for 32 bit ARM architecture. This is useful when compiling Electron apps that are supposed to also work on Raspberry Pi (most userlands are 32 bit there).
Alternate Designs
Not having a prebuilt binary means that every app needs to be compiled on a separate machine, which is painful.
Possible Drawbacks
None that I can think of
Verification Process
Release Notes