Introduced default type parameters to simplify reviewer and editor su…

…pport
atomist · Oct 11, 2017 · ba1117b · ba1117b
1 parent 06a4673
commit ba1117b
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/src/operations/edit/projectEditor.ts b/src/operations/edit/projectEditor.ts
@@ -5,7 +5,7 @@ import { RepoId } from "../common/RepoId";
 /**
  * Modifies the given project, returning information about the modification.
  */
-export type ProjectEditor<ER extends EditResult> =
+export type ProjectEditor<ER extends EditResult = EditResult> =
     (id: RepoId, p: Project, context: HandlerContext) => Promise<ER>;
 
 /**

diff --git a/src/operations/review/ReviewerCommandSupport.ts b/src/operations/review/ReviewerCommandSupport.ts
@@ -12,7 +12,9 @@ import { ProjectReview, ReviewResult } from "./ReviewResult";
  * Support for reviewing multiple projects
  * Subclasses should have @CommandHandler annotation
  */
-export abstract class ReviewerCommandSupport<RR extends ReviewResult<PR>, PR extends ProjectReview>
+export abstract class ReviewerCommandSupport<
+        RR extends ReviewResult<PR> = ReviewResult<PR>,
+        PR extends ProjectReview = ProjectReview>
     extends LocalOrRemoteRepoOperation
     implements HandleCommand {
 

diff --git a/src/operations/review/projectReviewer.ts b/src/operations/review/projectReviewer.ts
@@ -6,5 +6,5 @@ import { ProjectReview } from "./ReviewResult";
 /**
  * Function that can review a project
  */
-export type ProjectReviewer<RR extends ProjectReview> =
+export type ProjectReviewer<RR extends ProjectReview = ProjectReview> =
     (id: RepoId, p: Project, context: HandlerContext) => Promise<RR>;
diff --git a/test/operations/review/ReviewerCommandSupport.ts b/test/operations/review/ReviewerCommandSupport.ts
@@ -0,0 +1,18 @@
+
+import "mocha";
+import { HandlerContext } from "../../../src/HandlerContext";
+import { ProjectReviewer } from "../../../src/operations/review/projectReviewer";
+import { ReviewerCommandSupport } from "../../../src/operations/review/ReviewerCommandSupport";
+
+describe("ReviewerCommandSupport", () => {
+
+    it("should compile", () => {
+        class MyReviewer extends ReviewerCommandSupport {
+
+            public projectReviewer(context: HandlerContext): ProjectReviewer {
+                throw new Error("I don't care if this works so long as it compiles");
+            }
+        }
+    });
+
+});