Skip to content

Commit

Permalink
Minor fixes & cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
David Dooling committed Nov 4, 2019
1 parent 32e988e commit 3095d26
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/goal/container/k8s.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export function k8sFulfillmentCallback(
if (!k8sScheduler.podSpec) {
throw new Error("KubernetesGoalScheduler has no podSpec defined");
}
const initContainer: k8s.V1Container = _.cloneDeep(k8sScheduler.podSpec.spec.containers[0]);
const initContainer = _.cloneDeep(k8sScheduler.podSpec.spec.containers[0]);
delete initContainer.lifecycle;
delete initContainer.livenessProbe;
delete initContainer.readinessProbe;
Expand Down
3 changes: 1 addition & 2 deletions lib/pack/k8s/KubernetesGoalScheduler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,7 @@ export function createJobSpec(podSpec: k8s.V1Pod, podNs: string, gi: GoalInvocat
}
if (!!data[ServiceRegistrationGoalDataKey]) {
_.forEach(data[ServiceRegistrationGoalDataKey], (v, k) => {
logger.debug(
`Service with name '${k}' and type '${v.type}' found for goal '${goalEvent.uniqueName}'`);
logger.debug(`Service with name '${k}' and type '${v.type}' found for goal '${goalEvent.uniqueName}'`);
if (v.type === K8sServiceRegistrationType.K8sService) {
const spec = v.spec as K8sServiceSpec;
if (!!spec.container) {
Expand Down
2 changes: 1 addition & 1 deletion test/goal/container/docker.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ describe("goal/container/docker", () => {
return;
}
try {
await execPromise("docker", ["pull", "alpine:3.9.4"]);
await execPromise("docker", ["pull", "alpine:3.9.4"], { timeout: 18000 });
} catch (e) {
// tslint:disable-next-line:no-invalid-this
this.skip();
Expand Down

0 comments on commit 3095d26

Please sign in to comment.