Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test_dir test if atomvm:posix_opendir/1 is not available #1489

Open
wants to merge 1 commit into
base: release-0.6
Choose a base branch
from

Conversation

pguyot
Copy link
Collaborator

@pguyot pguyot commented Jan 23, 2025

Could happen with CI for s390x

https://github.com/atomvm/AtomVM/actions/runs/12923981002/job/36043219011?pr=1486#step:7:755

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w04/skip-dir-test-if-unavailable branch from 3f5242e to 7f981c0 Compare January 23, 2025 21:05
@bettio
Copy link
Collaborator

bettio commented Jan 23, 2025

Last time I had issues with posix_opendir was because I needed to add a -D_FILE_OFFSET_BITS=64 build flag.

Copy link
Collaborator

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One more flappy test solved. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants