Add gpio:set_int/4 for ESP32 and STM32
#837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
2 times, most recently
from
134e7d7
to
c885897
Compare
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
3 times, most recently
from
4ff1271
to
76f17c6
Compare
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
from
76f17c6
to
8376f88
Compare
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
2 times, most recently
from
5d0d821
to
f5858ae
Compare
fadushin
requested changes
Dec 6, 2023
| @@ -581,44 +602,37 @@ static term nif_gpio_digital_read(Context *ctx, int argc, term argv[]) | |||
| return gpio_digital_read(argv[0]); | |||
| } | |||
|
|
|||
| static const struct Nif gpio_set_pin_mode_nif = | |||
| { | |||
| static const struct Nif gpio_set_pin_mode_nif = { | |||
There was a problem hiding this comment.
Was this an editor doing auto-indent? We should probably restore this to the convention of curly braces on new lines for struct declarations.
There was a problem hiding this comment.
No, I had a CI format failure and ran clang-format-16 on the file... this was the result. I hadn't noticed that, I'll fix it.
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
from
f5858ae
to
d68cb76
Compare
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
2 times, most recently
from
dd54017
to
e23d60d
Compare
Done. And I added a TODO to move the GPIO atoms from platform_defaultatoms into the gpio_driver. |
bettio
requested changes
Dec 10, 2023
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
4 times, most recently
from
7d0025f
to
bec6698
Compare
bettio
approved these changes
Dec 17, 2023
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
from
bec6698
to
61e8d49
Compare
bettio
reviewed
Dec 20, 2023
Allows setting the pid() or registered name of the process to receive GPIO interrupt messages as the fourth parameter of `gpio:set_int/4`, for both ESP32 and STM32 GPIO port drivers. Signed-off-by: Winford <[email protected]>
UncleGrumpy
force-pushed
the
gpio.set_int-4
branch
from
61e8d49
to
520c616
Compare
|
Not at all. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting the
pid()or registered name of the process to receivegpio_interruptmessages as the fourth parameter ofgpio:set_int/4, with both ESP32 and STM32 GPIO port drivers.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later