Remove esp32 specific code from network #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to purge this from the documentation, as well. https://www.atomvm.net/doc/master/network-programming-guide.html#nvs-credentials (There might other references to NVS is this guide, so a scan might be needed) Also probably list in "Breaking Changes" in the change log (not that anyone is listening, but...) |
pguyot
force-pushed
the
w40/remove-esp32-code-from-network
branch
from
74f2052
to
2eb5858
Compare
fadushin
reviewed
Oct 7, 2023
Also purge documentation of this feature. Signed-off-by: Paul Guyot <[email protected]>
pguyot
force-pushed
the
w40/remove-esp32-code-from-network
branch
from
2eb5858
to
a2be24d
Compare
bettio
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later