Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish missing wasm file #854

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Conversation

bettio
Copy link
Collaborator

@bettio bettio commented Oct 7, 2023

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Just avoid cluttering scripts with `&&`.

Signed-off-by: Davide Bettio <[email protected]>
@bettio bettio force-pushed the publish-missing-wasm-file branch 2 times, most recently from 7e5da82 to 544aa88 Compare October 7, 2023 12:11
AtomVM.js, AtomVM.worker.js and AtomVM.wasm are all needed.
Also remove the webserver example app.

Signed-off-by: Davide Bettio <[email protected]>
Publish node version, and add suffix (node, web) to both.

Signed-off-by: Davide Bettio <[email protected]>
Copy link
Collaborator

@pguyot pguyot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned a zip or tar.gz might be more convenient as users will
have to rename the files back.

Also we could have a separate job for releasing the files, but this version wastes less CPU.

@bettio bettio merged commit 67adefa into atomvm:master Oct 7, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants