Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMAC API #33

Draft
wants to merge 10 commits into
base: development
Choose a base branch
from
Draft

GMAC API #33

wants to merge 10 commits into from

Conversation

tmplt
Copy link
Member

@tmplt tmplt commented Sep 17, 2022

Copied from an internal Gitlab instance. By @martinmortsell.

@martinmortsell
Copy link
Contributor

I put some effort into adding configuration options to the new_gmac() method.
Now mii/rmii, speed, duplex, and mac can be configured by the user.

The tx/rx buffers are still hardcoded in the HAL, I envision an api similar to the heapless::Vec where buffers are defined through const generics and maybe stored in the Gmac struct.

Interrupt support is still missing.

@michalfita
Copy link
Collaborator

@martinmortsell this PR is a draft that doesn't pass CI. Any change to get this finished here?

@martinmortsell
Copy link
Contributor

This code definitely needs another pass before merging.
Currently the big issue is that there is no guarantee that the frame buffers are placed statically in memory. As a user one can get around that by declaring the buffers as static. However, that's not really good enough to merge.

Other changes that should be done is clean up the generic variables, and add a feature gate to the smoltcp implementation.

Maybe I'll have time to fiddle with this during the autumn sometime, we'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants