README: Mention about git submodule #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ZhanYF you'll need to add a sign-off commit for the DCO check. You can do it with: git commit --amend -s
git push -fassuming you have an email setup with your git config. |
|
Done, thanks for the hints. |
Comment on lines
+74
to
+75
| cd libvmm | ||
| git submodule update --init |
There was a problem hiding this comment.
I messed up the suggestion sorry, there should still be three back ticks at the end and then a new line.
There was a problem hiding this comment.
Got it, should be good now.
Co-authored-by: Ivan Velickovic <[email protected]> Signed-off-by: Yifei Zhan <[email protected]>
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before libvmm can be built, the git submodule for sddf must be initialized first, this PR mentions about it in the README.
Most people using this repository probably know enough about git submodule to do it when make fail in the first run but I think it's still a good idea to document it.