fix(webpack.config.template.js): webpack resolving child node_modules #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM |
|
@EisenbergEffect we urgently have to revert this change from: back to And reopen the closed #961. We give up default webpack module resolutioin algorithm, and use only top level node_modules packages. That creates wrong version of module being packed. #1037 |
|
@huochunpeng I've re-opened the issue. Ping me on the PR to revert and I can do a CLI release tonight. |
EisenbergEffect
added a commit
that referenced
this pull request
Feb 5, 2019
fix(webpack): revert #970 to restore default webpack module resolution
This was referenced Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #961, when a symlinked package (i.e. a lerna monorepo) exists in node_modules, the child node_modules are resolved in webpack, creating duplicate module ids like './node_modules/symlinked-package/node_modules/some-dependency/index.js' in addition to './node_modules/some-dependency/index.js'.