fix(history-browser): browser history state not empty on new entries … #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidloki
added a commit
to sidloki/aurelia-onsenui
that referenced
this pull request
May 8, 2017
|
@davismj Can you investigate this? |
|
@davismj or @bryanrsmith can you review this? |
|
I should have time to review it tomorrow. |
|
I'm looking at this. I was able to reproduce the issue, but I built this and included it and it didn't work. I have a feeling its a problem with my internet explorer so I'm going to keep testing. |
|
@davismj Have you also applied aurelia/router#490? |
|
Yes. I'm gunna keep looking into it. |
|
@davismj Can you look into this again? |
|
Might be irrelevant in light of recent changes to router (1.5.0) |
|
Not sure it's irrelevant, the IE/Edge bug/deviant behaviour might still be there. |
|
Any update on this? |
…in IE/Edge Necessary for PR aurelia/router/history-state-consolidation
jwx
force-pushed
the
history-state-consolidation
branch
from
971708a
to
6334e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in IE/Edge
Necessary for PR aurelia/router/history-state-consolidation