Fix: update toolchain clippy, fix clippy. Fix vulnarabilities #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksuss
approved these changes
Aug 9, 2024
birchmd
approved these changes
Aug 9, 2024
runtime/src/lib.rs
Outdated
| @@ -445,7 +465,8 @@ impl Config { | |||
|
|
|||
| // See https://eips.ethereum.org/EIPS/eip-3529 | |||
| let refund_sstore_clears = if decrease_clears_refund { | |||
| (gas_sstore_reset + gas_access_list_storage_key) as i64 | |||
| // Avoid signed casting to unsigned as it'll overflow | |||
There was a problem hiding this comment.
Suggested change
| // Avoid signed casting to unsigned as it'll overflow | |
| // Avoid unsigned casting to signed as it may overflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
➡️ Updated rust toolchain to
⚠️ Found and fixed vulnerabilities related to
1.80.0➡️ Added
clippy::pedantic➡️ Fixed new clippy issues
signed->unsignedcasting. It affectsgas_usedcalculations. In some cases, it was possible cases, when castingi64->u64could produce an unexpected number, andgas_usedcalculation may produce wrong result.➡️ Fixed casting logic for
u64->usizeas it can produce truncated numbers fro 32-bit systems (likewasm32)➡️ Improved numbers casting logic
➡️ Added
clippy::as_conversions