Add yarn.lock to the project #237
Conversation
| @@ -50,7 +50,7 @@ | |||
| "s3": "^4.4.0", | |||
| "scrypt": "^6.0.3", | |||
| "tabookey-gasless": "^0.3.3-a", | |||
| "web3": "1.0.0-beta.33" | |||
| "web3": "1.0.0-beta.55" | |||
There was a problem hiding this comment.
Ah, sorry I had approved already.
Bit hesitant now to just bump the web3 version as those beta versions all have their own weird little bugs and quirks. Why did you do that?
@austintgriffith @dmihal thoughts?
There was a problem hiding this comment.
Hey @TimDaub! Thanks for the review. One of the reasons I went with it is because burner-core seems to be using it: https://github.com/austintgriffith/burner-core/blob/develop/core/package.json#L10
If you think it's not safe, I can back out that commit.
|
Hey, I added yarn.lock in one of my PRs a few weeks ago, so I'm not sure if this is necessary. Also I agree wit @TimDaub, we should be careful about bumping Web3 versions because of all the bugs. Eventually, web3 will be completely removed from this project and only used in burner-core, so I don't know if we need to worry too much about the different versions right now. |
|
Just checked and it looks like whatever PR included the yarn.lock was merged since I opened this one. Guess we can close this one out. |
This PR enables usage of the yarn package manager with the project. When using yarn, builds are deterministic. It's still possible to use npm with the project without any changes. Builds will not be deterministic with npm-- unless we check in the
package-lock.json. (See here)This PR also upgrades the patch versions where possible.
Let me know thoughts on this change. I can also update the README instructions to cover
yarnusage.Closes #216