Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yarn.lock to the project #237

Closed
wants to merge 4 commits into from
Closed

Add yarn.lock to the project #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2a1cea
Import the yarn.lock file
apbendi Jun 27, 2019
2f9c13f
Run yarn upgrade
apbendi Jun 27, 2019
eacce9e
Update to latest beta of web3
apbendi Jun 27, 2019
8d0c2c7
Upgrade clevis
apbendi Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"s3": "^4.4.0",
"scrypt": "^6.0.3",
"tabookey-gasless": "^0.3.3-a",
"web3": "1.0.0-beta.33"
"web3": "1.0.0-beta.55"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry I had approved already.

Bit hesitant now to just bump the web3 version as those beta versions all have their own weird little bugs and quirks. Why did you do that?
@austintgriffith @dmihal thoughts?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TimDaub! Thanks for the review. One of the reasons I went with it is because burner-core seems to be using it: https://github.com/austintgriffith/burner-core/blob/develop/core/package.json#L10

If you think it's not safe, I can back out that commit.

},
"scripts": {
"start": "PORT=3000 react-scripts start",
Expand All @@ -70,7 +70,7 @@
],
"devDependencies": {
"chai": "^4.2.0",
"clevis": "^0.2.11",
"clevis": "^0.2.16",
"mocha": "^5.2.0",
"openzeppelin-solidity": "^2.3.0",
"webpack": "^4.28.4"
Expand Down
Loading