Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android App Links guidance to https schemes #324

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

ajyong
Copy link
Contributor

@ajyong ajyong commented Oct 23, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Surfacing an important step when setting up Android apps to support https schemes.

📎 References

Aligning the Pub.dev docs with the same level of convenience as guidance found in other Auth0 documentation surrounding the use of https schemes:

🎯 Testing

Docs-only change, should not affect tests.

@ajyong ajyong requested a review from a team as a code owner October 23, 2023 22:17
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ajyong!

@Widcket Widcket enabled auto-merge (squash) October 26, 2023 20:22
@ajyong ajyong temporarily deployed to external October 26, 2023 21:56 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (90fdb60) 95.79%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #324      +/-   ##
============================================
- Coverage     96.08%   95.79%   -0.30%     
============================================
  Files            97       76      -21     
  Lines          1611     1118     -493     
  Branches        331      281      -50     
============================================
- Hits           1548     1071     -477     
+ Misses           49       46       -3     
+ Partials         14        1      -13     
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android ?
auth0_flutter_ios ?
auth0_flutter_platform_interface 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajyong ajyong temporarily deployed to external October 26, 2023 22:03 — with GitHub Actions Inactive
@ajyong ajyong temporarily deployed to external October 26, 2023 22:03 — with GitHub Actions Inactive
@ajyong ajyong temporarily deployed to external October 26, 2023 22:03 — with GitHub Actions Inactive
@Widcket Widcket merged commit a3ec435 into auth0:main Oct 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants