Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ship package labels #325

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Add Ship package labels #325

merged 3 commits into from
Oct 27, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 26, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

This PR adds a new packageLabel property to the Ship config files for each package (auth0_flutter and auth0_flutter_platform_interface).

Going forward, releases will be tagged separately for each package, as the release automation introduced in #278 needs separate tags. The value of packageLabel will be prepended to each tag, matching the values defined in the respective GitHub actions workflow:

This way, creating a labeled tag will kick off the release action for the respective package.

@Widcket Widcket added the review:tiny Tiny review label Oct 26, 2023
@Widcket Widcket requested a review from a team as a code owner October 26, 2023 22:00
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:00 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:00 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:00 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:00 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:00 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (253209a) 96.08% compared to head (eb71339) 95.79%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #325      +/-   ##
============================================
- Coverage     96.08%   95.79%   -0.30%     
============================================
  Files            97       76      -21     
  Lines          1611     1118     -493     
  Branches        331      281      -50     
============================================
- Hits           1548     1071     -477     
+ Misses           49       46       -3     
+ Partials         14        1      -13     
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android ?
auth0_flutter_ios ?
auth0_flutter_platform_interface 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket temporarily deployed to internal October 26, 2023 22:14 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:14 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:14 — with GitHub Actions Inactive
@Widcket Widcket temporarily deployed to internal October 26, 2023 22:14 — with GitHub Actions Inactive
@Widcket Widcket merged commit f38fd07 into main Oct 27, 2023
13 checks passed
@Widcket Widcket deleted the chore/ship-package-labels branch October 27, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants