[Settings v2] Use history back for settings v2 pages navbar #4804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IniZio
changed the title
IniZio
changed the title
|
Build failed. |
IniZio
force-pushed
the
DEV-2094-settings-back-button
branch
3 times, most recently
from
a8bd639 to
e6c49d3
Compare
louischan-oursky
requested changes
Oct 9, 2024
IniZio
force-pushed
the
DEV-2094-settings-back-button
branch
from
e6c49d3 to
b17bef1
Compare
louischan-oursky
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-2094
Initially wanted to hide back button when there is no prior history. However
window.history.lengthactually always return all backword + forward navigations.We cannot reliably check if current page is the last item in the stack