Update api and add api update logic #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
commented
Nov 4, 2024
Comment on lines
+257
to
+261
| if ((tag & 7) == 4) { | ||
| // Abort on any end group tag. | ||
| return; | ||
| } | ||
| switch(tag) { |
There was a problem hiding this comment.
These changes are present in most files; I imagine this is due to a new protobuf version rather than anything that buf is doing. Note that these files don't contain an annotation of the version of protobuf used to generate them, unlike other languages.
vroldanbet
approved these changes
Nov 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of bringing in 1.38.0. Also converts the lib to use remote plugins, which allows us to use the automatic version bumping workflows.
Changes
Testing
Review. See that tests are green.