Add additional check to elide writing empty transaction metadata

authzed · Nov 5, 2024 · 4c15452 · 4c15452
1 parent 0d5b21b
commit 4c15452
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/internal/datastore/crdb/crdb.go b/internal/datastore/crdb/crdb.go
@@ -338,7 +338,7 @@ func (cds *crdbDatastore) ReadWriteTx(
 		}
 
 		// If metadata is to be attached, write that row now.
-		if config.Metadata != nil {
+		if config.Metadata != nil && len(config.Metadata.GetFields()) > 0 {
 			expiresAt := time.Now().Add(cds.gcWindow).Add(1 * time.Minute)
 			insertTransactionMetadata := psql.Insert(tableTransactionMetadata).
 				Columns(colExpiresAt, colMetadata).

diff --git a/internal/datastore/memdb/memdb.go b/internal/datastore/memdb/memdb.go
@@ -205,7 +205,7 @@ func (mdb *memdbDatastore) ReadWriteTx(
 
 		tracked := common.NewChanges(revisions.TimestampIDKeyFunc, datastore.WatchRelationships|datastore.WatchSchema, 0)
 		if tx != nil {
-			if config.Metadata != nil {
+			if config.Metadata != nil && len(config.Metadata.GetFields()) > 0 {
 				if err := tracked.SetRevisionMetadata(ctx, newRevision, config.Metadata.AsMap()); err != nil {
 					return datastore.NoRevision, err
 				}

diff --git a/internal/datastore/postgres/postgres.go b/internal/datastore/postgres/postgres.go
@@ -438,7 +438,7 @@ func (pgd *pgDatastore) ReadWriteTx(
 		err = wrapError(pgx.BeginTxFunc(ctx, pgd.writePool, pgx.TxOptions{IsoLevel: pgx.Serializable}, func(tx pgx.Tx) error {
 			var err error
 			var metadata map[string]any
-			if config.Metadata != nil {
+			if config.Metadata != nil && len(config.Metadata.GetFields()) > 0 {
 				metadata = config.Metadata.AsMap()
 			}
 

diff --git a/internal/datastore/spanner/spanner.go b/internal/datastore/spanner/spanner.go
@@ -272,7 +272,7 @@ func (sd *spannerDatastore) ReadWriteTx(ctx context.Context, fn datastore.TxUser
 			return &traceableRTX{delegate: spannerRWT}
 		}
 
-		if config.Metadata != nil {
+		if config.Metadata != nil && len(config.Metadata.GetFields()) > 0 {
 			// Insert the metadata into the transaction metadata table.
 			mutation := spanner.Insert(tableTransactionMetadata,
 				[]string{colTransactionTag, colMetadata},