console log when we exceed 1000ms for a load #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can absolutely see the value in this. Is it worth making it optional? |
|
yea, it should probably be tied to a debug setting. i'll update the patch. |
Create a performance log that can be used accross automerge-repo
|
I've added a generic perfLogger that can be used across automerge-repo to log performance information. So if you want to show perf information, you can add "automerge-repo:perf" to DEBUG. |
|
I'm going to drop this PR -- I still think it's a good idea and we can revive it later but it's not an active problem and I think building on the perfLogger model would be a better plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any objection? I usually avoid checking in
console.warns()but at least at the moment I want to emphasize finding and fixing these slow documents.