Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useRepo tests #242

Closed
wants to merge 2 commits into from
Closed

useRepo tests #242

wants to merge 2 commits into from

Conversation

HerbCaudill
Copy link
Collaborator

In useRepo.test.tsx, there's a floating assertion that confirms that a repo can be instantiated with no network:

const repo = new Repo({
network: [],
})
expect(repo).toBeInstanceOf(Repo)
// TODO: @pvh: Move this test to automerge-repo
test.skip("should `new Repo({ network: [] })` work")

This PR moves that into a proper test in Repo.test.ts:

describe("constructor", () => {
it("can be instantiated without network adapters", () => {
const repo = new Repo({
network: [],
})
expect(repo).toBeInstanceOf(Repo)
})
})

@@ -2,6 +2,7 @@ import { defineConfig } from "vitest/config"

export default defineConfig({
test: {
globals: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HerbCaudill HerbCaudill requested a review from pvh December 4, 2023 14:13
@HerbCaudill HerbCaudill changed the base branch from main to coverage-config December 5, 2023 13:28
@HerbCaudill HerbCaudill mentioned this pull request Dec 5, 2023
@HerbCaudill
Copy link
Collaborator Author

HerbCaudill commented Dec 5, 2023

@pvh
Copy link
Member

pvh commented Dec 20, 2023

Merged already, thanks! (I guess I didn't push the rebase.)

@pvh pvh closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants