-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useRepo tests #242
useRepo tests #242
Conversation
@@ -2,6 +2,7 @@ import { defineConfig } from "vitest/config" | |||
|
|||
export default defineConfig({ | |||
test: { | |||
globals: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, I was getting this warning on each test run:
https://stackoverflow.com/questions/77494496/vitest-warning-the-current-test-runner-does-not-support-aftereach-teardown-hook
4e426f7
to
787f36e
Compare
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
d0c2e31
to
b257251
Compare
787f36e
to
694b532
Compare
b257251
to
1c41e4d
Compare
694b532
to
da69dfd
Compare
Merged already, thanks! (I guess I didn't push the rebase.) |
In
useRepo.test.tsx
, there's a floating assertion that confirms that a repo can be instantiated with no network:automerge-repo/packages/automerge-repo-react-hooks/src/useRepo.test.tsx
Lines 8 to 14 in d73e715
This PR moves that into a proper test in
Repo.test.ts
:automerge-repo/packages/automerge-repo/test/Repo.test.ts
Lines 34 to 41 in 4e426f7