-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add signOut #35
Conversation
Walkthrough新しい機能として、 Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User as ユーザー
participant AddTenant as AddTenantコンポーネント
participant Dashboard as Dashboardコンポーネント
participant AuthService as Authサービス
participant HomePage as ホームページ
User->>AddTenant: 「ログアウト」ボタンをクリック
AddTenant->>AuthService: signOutUser()を呼び出す
AuthService->>User: サインアウト成功
AddTenant->>HomePage: リダイレクト
User->>Dashboard: 「ログアウト」ボタンをクリック
Dashboard->>AuthService: signOutUser()を呼び出す
AuthService->>User: サインアウト成功
Dashboard->>HomePage: リダイレクト
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Visit the preview URL for this PR (updated for commit 97369e0): https://autonomy-tegata-dev--pr35-feat-add-signout-fun-ab5cdfsa.web.app (expires Sun, 09 Jun 2024 02:12:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 372cb972329a2dd7e3813bc6bde2f0d317d6488e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- app/src/contents/tenant/addTenant.tsx (2 hunks)
- app/src/pages/dashboard.tsx (2 hunks)
- app/src/service/auth.ts (2 hunks)
onClick={async () => { | ||
await signOutUser(); | ||
window.location.href = "/"; | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ログアウト処理にエラーハンドリングを追加することをお勧めします。
onClick={async () => {
try {
await signOutUser();
window.location.href = "/";
} catch (error) {
console.error('Logout failed:', error);
// Handle error appropriately
}
}}
Summary by CodeRabbit