Limit concurrency of piece retrieval from node via RPC #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
limit-node-piece-retrieval-concurrency
branch
from
47646f8
to
ccd79b2
Compare
shamil-gadelshin
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in paritytech/jsonrpsee#1189 node right now is having a hard time serving piece retrieval requests. In local setup by sending too many most will time out in 60 secodns, triggering piece reconstruction, making things even worse in terms of time it takes to plot a sector.
Limiting it to low number fixes the issue and should only really affect local setup since in acctual network L2 DSN cache should be able to serve most (ideally all) requests.
Code contributor checklist: