Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON decoding is apparently quite costly for pieces, so new archived segment causes head-of-line blocking on RPC connection and apparently this results in some subscriptions to silently break somewhere in jsonrpsee (see paritytech/jsonrpsee#1409). Not sure what breaks, where or why, but this change makes a lot of sense either way.
Before:
After:
So even with fresh farmer in dev network initial piece cache sync is measurably faster. We'll see if this is sufficient, didn't want to use
tokio::task::spawn_blocking
here (though it is an option if we want to offload decoding compute out of async code completely).Code contributor checklist: