domtime: update for s390x #5936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
smitterl
force-pushed
the
fix_domtime_s390x
branch
from
646938a
to
ae796a0
Compare
chunfuwen
reviewed
Oct 15, 2024
| @@ -3,23 +3,36 @@ | |||
| start_vm = no | |||
| take_regular_screendumps = "no" | |||
| vm_stop_duration = 10 | |||
| s390-virtio: | |||
| positive: | |||
There was a problem hiding this comment.
I think line 7 ~ line 10 are not necessary since you already add no s390-virtio in respective variant name.
There was a problem hiding this comment.
@chunfuwen You are right there is duplication but the intention of 7-10 is exactly to prevent each variant from having its own 'no s390-virtio', this way all config is in one place. So I removed the subvariant specific 'no s390-virtio' filters.
hwclock is not available on s390x and guest agent operators that modify the time either. 1. Don't try to restore time (with --now flag) during teardown. 2. Disable test cases that try to modify time. 3. Skip step that uses hwclock. Signed-off-by: Sebastian Mitterle <[email protected]>
smitterl
force-pushed
the
fix_domtime_s390x
branch
from
ae796a0
to
e3b4157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hwclock is not available on s390x and guest agent operators that modify the time either.