SRIOV: add new test case of dma_translation for vIOMMU #5937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chunfuwen
reviewed
Oct 15, 2024
| @@ -33,6 +33,8 @@ def run(test, params, env): | |||
| vmxml.features = features | |||
| vmxml.sync() | |||
| err_msg = '' | |||
| if libvirt_version.version_compare(10, 7, 0) and iommu_dict['model'] == 'intel': | |||
| iommu_dict['driver']['dma_translation'] = 'on' | |||
There was a problem hiding this comment.
dma_translation is new feature, so maybe create separate case under intel variant of ./libvirt/tests/cfg/sriov/vIOMMU/attach_iommu_device.cfg , otherwise it is easy to ignore this feature if still under previous test case.
There was a problem hiding this comment.
I've considered whether we need to add a new case. But after the evaluation I gave up because:
- Keep the same attributes strategy as before in plan.
- This new attribute is not so important because before it was enabled default.
Certainly it can also reduce our debug workloads.
|
@Yingshun Could you help review this PR? Thanks. |
Yingshun
requested changes
Oct 25, 2024
Automate new dma_translation attribute for vIOMMU: VIRT-302220 - [vIOMMU][intel] Start VM with intel iommu and dma_translation attribute Signed-off-by: Meina Li <[email protected]>
meinaLi
changed the title
|
Yingshun
reviewed
Nov 1, 2024
| iommu_dict = eval(params.get("iommu_dict", "{}") % dma_translation) | ||
| with_more_vcpus = "yes" == params.get("with_more_vcpus", "no") | ||
| test_obj = viommu_base.VIOMMUTest(vm, test, params) | ||
| libvirt_version.is_libvirt_feature_supported(params) |
There was a problem hiding this comment.
It's covered in viommu_base.VIOMMUTest(), plz remove it.
| type = intel_iommu_with_dma_translation | ||
| start_vm = "yes" | ||
| enable_guest_iommu = "yes" | ||
| iommu_dict = {'model': 'intel', 'driver': {'intremap': 'on', 'caching_mode': 'on', 'iotlb': 'on', 'dma_translation': '%s'}} |
There was a problem hiding this comment.
I think it's better to move this line to the end of this file and use the variant 'dma_translation' to show the iommu settings for each tests:
iommu_dict = {'model': 'intel', 'driver': {'intremap': 'on', 'caching_mode': 'on', 'iotlb': 'on', 'dma_translation': 'dma_translation'}}
| iommu_dict['driver'].update(eim_dict) | ||
| test.log.info("TEST STEP1: Prepare guest xml with intel iommu device.") | ||
| test_obj.setup_iommu_test(iommu_dict=iommu_dict) | ||
| vmxml = vm_xml.VMXML.new_from_dumpxml(vm_name) |
There was a problem hiding this comment.
It's only used for L27-29, I think it can be moved into the if statement.
| vmxml.vcpu = int(guest_vcpus) | ||
| vmxml.sync() | ||
| test.log.info("TEST STEP2: Start the guest.") | ||
| virsh.start(vm_name, debug=True) |
There was a problem hiding this comment.
It's better to use vm.start which will raise exceptions if the startup fails.
| test.log.info("TEST STEP3: Check the message for iommu group and DMA.") | ||
| vm.cleanup_serial_console() | ||
| vm.create_serial_console() | ||
| vm_session = vm.wait_for_serial_login(timeout=6000) |
There was a problem hiding this comment.
Why do we expect the timeout to be so long? 6000s is too long in my opinion, what do you think?
Comment on lines
+40
to
+43
| if dma_translation == "on" and (not dma_status or iommu_status): | ||
| test.fail("Can't get expected message result when enabling dma_translation.") | ||
| if dma_translation == "off" and (dma_status or not iommu_status): | ||
| test.fail("Can't get expected message result when disabling dma_translation.") |
There was a problem hiding this comment.
It's better to log the outputs of above 2 shell commands - 'dmesg | xxx'
| if with_more_vcpus: | ||
| s, o = vm_session.cmd_status_output("cat /proc/cpuinfo | grep processor| wc -l") | ||
| if int(o) != int(guest_vcpus): | ||
| test.fail("Can't get expected vCPU number, the actual number is %s" % type(o)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate new dma_translation attribute for vIOMMU:
VIRT-302220 - [vIOMMU][intel] Start VM with intel iommu and dma_translation attribute