case update: add new disk to check domblkthreshold #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxxx-294599: Do domblkthreshold for device with backing chain element Signed-off-by: nanli <[email protected]>
meinaLi
reviewed
Oct 23, 2024
| test_obj.backingchain_common_setup(create_snap=True, | ||
| snap_num=4) | ||
| snap_num=4, extra=snap_extra) | ||
| test.log.debug(vm_xml.VMXML.new_from_dumpxml(vm.name)) |
There was a problem hiding this comment.
I suggest to add stdout_text to make the output more clear to debug.
| domblk_threshold = '1' | ||
| actual_domblk = "1" |
There was a problem hiding this comment.
From our discussion, I think actual_threshold is more better to describe the expected bytes.
| actual_domblk = "1" | ||
| disk_type = "file" | ||
| disk_image_format = "raw" | ||
| disk_dict = {"type_name":"${disk_type}", "target":{"dev": "${target_disk}", "bus": "virtio"}, "driver": {"name": "qemu", "type":"raw"}} |
There was a problem hiding this comment.
The variant disk_image_format is not used here. I think maybe you want to use it to instead type:
disk_dict = {......"driver": {"name": "qemu", "type": "${disk_image_format}"}}
A space also should be added after "type":.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxxx-294599: Do domblkthreshold for device with backing chain element
Signed-off-by: nanli [email protected]