Virt_admin_logging: create local disk and clear messages log #5942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
TestFail: Check message log:journal failed in log file:/var/log/messages
More specifically:
Fix:
Run create_local_disk() to ensure that no_existed_journal.qcow2 exists.
Additionally, since in some cases, this test case checks the entirety of /var/log/messages (which contains logs from all test runs) for the key word "journal" to determine whether the test passes/fails, this failure causes subsequent tests to pass because "journal" is present in the error message. To fix this, /var/log/messages is cleared at the beginning of the test run to make sure that the only messages checks are ones that were logged during that specific test run.
Tests passing: